feat(ctl): Add support for stacklet credentials subcommand
#108
Conversation
|
To conditionally display the |
| } | ||
|
|
||
| #[derive(Debug, Snafu)] | ||
| pub enum StackletError { | ||
| #[snafu(display("kubernetes error"))] | ||
| #[snafu(display("kubernetes error"), context(false))] |
There was a problem hiding this comment.
Really don't love this, if anything I'd like to get rid of these "oh this library failed" catch-alls entirely.
There was a problem hiding this comment.
Generally agreed, but let's maybe tackle this in #55
| Ok(credentials) => credentials, | ||
| Err(err) => match err { | ||
| CredentialsError::KubeError { source } => return Err(source.into()), | ||
| CredentialsError::NoSecret => None, |
There was a problem hiding this comment.
Is there much value to treating this as a separate condition in get_credentials if we just end up flattening it back into None afterwards?
There was a problem hiding this comment.
I feel like the get_credentials function should report this error. The implementer (stackablectl) chooses to map it to None, which indicates that no credentials output should be printed.
The command currently fails with an 404 error. It seems like that the k8s API is unable to find the requested object.
Techassi
changed the title
--show-credentials in stacklets list commandstacklet credentials subcommand
|
For the record: a52b933 fixes the 404 error, happy to explain it offline |
There was a problem hiding this comment.
Command worked for me 👍
➜ stackable-cockpit git:(feat/credential-output) cargo r -p stackablectl -- stacklet credentials --product-namespace sbernauer superset simple-superset
Credentials for superset (simple-superset) in namespace 'sbernauer':
USERNAME admin
PASSWORD admin
In case i changed stacklet.data["spec"]["clusterConfig"]["credentialsSecret"] to stacklet.data["spec"]["clusterConfig"]["credentialsSecret123"] it showed No credentials and did not give an error.
This is good, as we will remove that field in the future.
Tracked by #98, closes #107
This adds support for credential output when using. They are only displayed when the user explicitly want to retrieve them via a dedicated subcommand. Using a subcommand makes this an opt-in, as the output contains sensitive data. Test it with:
The implementation is not final and will change with the introduction of Discovery 2.0.
Currently blocked by #106Currently blocked by #113