Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make spark-env.sh configurable #473

Merged
merged 13 commits into from
Oct 7, 2024
Merged

feat: Make spark-env.sh configurable #473

merged 13 commits into from
Oct 7, 2024

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Oct 2, 2024 •
edited by adwk67
Loading

Description

Make spark-env.sh configurable via configOverrides

part of #464

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@siegfriedweber siegfriedweber requested a review from a team October 2, 2024 15:43
@siegfriedweber siegfriedweber self-assigned this Oct 2, 2024
@siegfriedweber siegfriedweber mentioned this pull request Oct 2, 2024
Closed
4 tasks
@siegfriedweber
Copy link
Member Author

siegfriedweber commented Oct 2, 2024 •
edited
Loading

❌ https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/9/

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Oct 3, 2024 •
edited
Loading

✅ https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/10/

@adwk67 adwk67 requested review from adwk67 and removed request for a team October 7, 2024 08:38
adwk67
adwk67 requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly minor things.

docs/modules/spark-k8s/pages/usage-guide/configuration-environment-overrides.adoc Outdated Show resolved Hide resolved
docs/modules/spark-k8s/pages/usage-guide/configuration-environment-overrides.adoc Outdated Show resolved Hide resolved
docs/modules/spark-k8s/pages/usage-guide/configuration-environment-overrides.adoc Outdated Show resolved Hide resolved
docs/modules/spark-k8s/pages/usage-guide/configuration-environment-overrides.adoc Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/spark_k8s_controller.rs Show resolved Hide resolved
adwk67
adwk67 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@siegfriedweber siegfriedweber added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 0a4923c Oct 7, 2024
31 checks passed
@siegfriedweber siegfriedweber deleted the feat/spark-env_sh branch October 7, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siegfriedweber @adwk67