fix(playbook): Retired files and local testing improvements #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NickLarsenNZ
commented
Oct 29, 2024
•
NickLarsenNZ
commented
- Use correct filename, and add missing file to the retired files list.
- Refactor the playbook to run more steps in the local test.
- Pull in a change from UserInfoFetcher: ActiveDirectory backend opa-operator#622.
Otherwise it gets removed, like stackabletech/opa-operator#641
NickLarsenNZ
changed the title
Techassi
previously approved these changes
Oct 29, 2024
This was referenced Oct 29, 2024
Instead of using git config --global, make the git config commands local to each operator repository. This is then safe to run via test.sh (dry-run).
Techassi
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.