Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Rust version and workflow actions #899

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 22, 2024

Description

Part of #898

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

While I think of it, there is the ubi9 image builder updates:
https://github.com/stackabletech/docker-images/blob/main/ubi9-rust-builder/Dockerfile#L13

This was normally taken care of in the product update tracking task but maybe it should become part of the same tracking issue as this?

stackabletech/docker-images#831
image

I will add a placeholder task in #898 for now.

@sbernauer
Copy link
Member Author

Unpopular opinion: I would bump the Rust version after a SDP release and keep it like that - as it does not offer any users benefits and we have stability before the release.
Anyway, I just wanted to mention this, but I'm sticking to the templates you created!

Also approved your PR, thanks for your review here!

@sbernauer sbernauer added this pull request to the merge queue Oct 23, 2024
@Techassi
Copy link
Member

I feel like this should be a task in the "Update Rust Toolchain of Operators" tracking issue template as the comment in the Dockerfile also mentions that the version should be kept in-sync with operator-templating.

Merged via the queue into main with commit 9e9d149 Oct 23, 2024
10 checks passed
@sbernauer sbernauer deleted the chore/bump-rust branch October 23, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants