Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stackable-versioned): Add 'use super::*' to generated version module #859

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Sep 6, 2024

Part of stackabletech/issues#507

This PR enables the user to use imported items in container definitions. Previously, the version modules limited the visibility of such items inside said module. Now, using use super::* the items can be accessed.

This issue was reported by @sbernauer after a first quick testing round.

@Techassi Techassi self-assigned this Sep 6, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a superstar (get it?)

@Techassi
Copy link
Member Author

Techassi commented Sep 6, 2024

Like a superstar (get it?)

Good one! 😂

@Techassi Techassi added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 3857d21 Sep 6, 2024
10 checks passed
@Techassi Techassi deleted the feat/crd-versioning-use-super branch September 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants