Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stackable-versioned-macros): Handle attribute forwarding / doc generation #816

Closed
wants to merge 7 commits into from

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jun 26, 2024

Description

Part of stackabletech/issues#507

  • Forward all struct and field attributes (this includes docs).
    ⚠️ There is a problem with adding derive attributes. Rust Analyzer panics.
  • Allow version specific docs that carry across to future versions

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@NickLarsenNZ
Copy link
Member Author

Closed in favour of #847 (it was easier to reimplement after the refactor, and deal with merge conflicts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant