Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stackable-versioned): Add support for versioned enums #813

Merged
merged 22 commits into from
Jul 5, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jun 17, 2024

Tracked by stackabletech/issues#507, currently blocked by #804

This PR adds support to version enums using the same attribute macro.

@Techassi Techassi self-assigned this Jun 17, 2024
@Techassi
Copy link
Member Author

This PR currently contains a bunch of duplicated code. Some of that duplication can and should be removed by some abstraction. This will be done in a follow-up PR.

@Techassi Techassi marked this pull request as ready for review June 28, 2024 08:20
@NickLarsenNZ NickLarsenNZ self-requested a review June 28, 2024 08:59
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just left some comments and suggestions

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit cca721a Jul 5, 2024
17 checks passed
@Techassi Techassi deleted the feat/crd-versioning-enum-support branch July 5, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants