Skip to content

Commit

Permalink
Generated commit to update templated files based on rev efb48ae in st…
Browse files Browse the repository at this point in the history
…ackabletech/operator-templating repo.

Triggered by:
Manual run triggered by: lfrancke with message [Fix Helm charts publish only once PR#413]
  • Loading branch information
stackable-bot committed Jul 24, 2024
1 parent c9684b9 commit 16a1077
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
Expand All @@ -22,7 +22,7 @@
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
```
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,13 @@ jobs:
make -e build
- name: Publish Docker image and Helm chart
if: ${{ !github.event.pull_request.head.repo.fork }}
run: make -e publish
run: |

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1009:info:2:1: The mentioned syntax error was in this if expression [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1009:info:2:1: The mentioned syntax error was in this if expression [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1035:error:2:4: You need a space after the [ and before the ] [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1035:error:2:4: You need a space after the [ and before the ] [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1073:error:2:4: Couldn't parse this test expression. Fix to allow more checks [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1073:error:2:4: Couldn't parse this test expression. Fix to allow more checks [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1020:error:2:30: You need a space before the ] [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1020:error:2:30: You need a space before the ] [shellcheck]

Check failure on line 371 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/build.yml#L371

shellcheck reported issue in this script: SC1072:error:2:30: Missing space before ]. Fix any mentioned problems and try again [shellcheck]
Raw output
.github/workflows/build.yml:371:9: shellcheck reported issue in this script: SC1072:error:2:30: Missing space before ]. Fix any mentioned problems and try again [shellcheck]
# We want to publish helmcharts only once as they have a common name, while still publishing both images with architecture specific tags
if ["$(uname -m)" = "x86_64"]; then
make -e publish
else
make -e docker-publish
fi
# Output the name of the published image to the Job output for later use
- id: printtag
name: Output image name and tag
Expand Down

0 comments on commit 16a1077

Please sign in to comment.