Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Getting-started scripts - working helm script #523

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Nov 3, 2023

Description

Commented out ExternalIP from helm callout as the json parsing does not work on e.g. kind
Stackablectl works fine.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care, just wanted to mention that this now probably stops working on clouds such as GKE. Azure and IONOS.
Proper solution is something like kubectl get svc keycloak -o json | jq -r --argfile endpoints <(kubectl get endpoints keycloak -o json) --argfile nodes <(kubectl get nodes -o json) '($nodes.items[] | select(.metadata.name == $endpoints.subsets[].addresses[].nodeName) | .status.addresses | map(select(.type == "ExternalIP" or .type == "InternalIP")) | min_by(.type) | .address | tostring) + ":" + (.spec.ports[] | select(.name == "http") | .nodePort | tostring)'
Anyway, will be removed after listener-op integration in any case ;)

@adwk67 adwk67 added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit d664aa3 Nov 3, 2023
29 checks passed
@adwk67 adwk67 deleted the docs/fix-getting-started-pre2311 branch November 3, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants