Skip to content

Commit

Permalink
Use patched version of op-rs that hopefully addresses SUP-148. (#717)
Browse files Browse the repository at this point in the history
* Use patched version of op-rs that hopefully addresses SUP-148.

* Updated cargo.lock to include new commits in op-rs pr (should be no significant changes, pretty much just comments and tests).

* Update revision of PR branch.

* Update revision of PR branch.

* Update to use released version of operator-rs and add Changelog entry.

* Change test condition to look for 'succeeded' instead of 'ready', as ready only becomes 1 for a brief moment and apparently kuttl can miss that..

* Run pre-commit

---------

Co-authored-by: Siegfried Weber <[email protected]>
  • Loading branch information
soenkeliebau and siegfriedweber authored Nov 25, 2024
1 parent c851f51 commit 29c3573
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ All notable changes to this project will be documented in this file.
- Failing to parse one `NifiCluster`/`AuthenticationClass` should no longer cause the whole operator to stop functioning ([#662]).
- NiFi will now use the JDK trust store when an OIDC provider uses WebPKI as CA ([#686], [#698]).
- Fix OIDC endpoint construction in case the `rootPath` does not have a trailing slash ([#718]).
- BREAKING: Use distinct ServiceAccounts for the Stacklets, so that multiple Stacklets can be deployed in one namespace. Existing Stacklets will use the newly created ServiceAccounts after restart ([#717]).

### Removed

Expand All @@ -51,6 +52,7 @@ All notable changes to this project will be documented in this file.
[#698]: https://github.com/stackabletech/nifi-operator/pull/698
[#702]: https://github.com/stackabletech/nifi-operator/pull/702
[#708]: https://github.com/stackabletech/nifi-operator/pull/708
[#717]: https://github.com/stackabletech/nifi-operator/pull/717
[#718]: https://github.com/stackabletech/nifi-operator/pull/718

## [24.7.0] - 2024-07-24
Expand Down
2 changes: 1 addition & 1 deletion tests/templates/kuttl/oidc/12_nifi.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
clusterConfig:
authentication:
- authenticationClass: nifi-oidc-auth-class-$NAMESPACE
oidc:
oidc:
clientCredentialsSecret: nifi-oidc-client
sensitiveProperties:
keySecret: nifi-sensitive-property-key
Expand Down
2 changes: 1 addition & 1 deletion tests/templates/kuttl/oidc/20-assert.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ kind: Job
metadata:
name: oidc-login-test
status:
ready: 1 # wait for the test job to start before streaming its logs in the next test step
succeeded: 1 # wait for the test job to start before streaming its logs in the next test step

0 comments on commit 29c3573

Please sign in to comment.