Skip to content

Commit

Permalink
Support Kafka 3.4.0 (#591)
Browse files Browse the repository at this point in the history
  • Loading branch information
maltesander and maltesander committed May 23, 2023
1 parent 6065e79 commit 87c5c5a
Show file tree
Hide file tree
Showing 15 changed files with 46 additions and 39 deletions.
2 changes: 1 addition & 1 deletion .readme/partials/main.md.j2
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
zookeeperConfigMapName: simple-kafka-znode
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ All notable changes to this project will be documented in this file.
- Generate OLM bundle for Release 23.4.0 ([#585]).
- Fixed upgrade test on Openshift ([#585]).
- Missing CRD defaults for `status.conditions` field ([#588]).
- Support Kafka 3.4.0 ([#591]).

### Changed

Expand All @@ -20,6 +21,7 @@ All notable changes to this project will be documented in this file.
[#584]: https://github.com/stackabletech/kafka-operator/pull/584
[#585]: https://github.com/stackabletech/kafka-operator/pull/585
[#588]: https://github.com/stackabletech/kafka-operator/pull/588
[#591]: https://github.com/stackabletech/kafka-operator/pull/591

## [23.4.0] - 2023-04-17

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
zookeeperConfigMapName: simple-kafka-znode
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/kafka/examples/getting_started/kafka.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
tls:
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/kafka/pages/config_properties.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
zookeeperConfigMapName: simple-kafka-znode
brokers:
Expand Down
8 changes: 4 additions & 4 deletions docs/modules/kafka/pages/usage-guide/security.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
zookeeperConfigMapName: simple-kafka-znode
Expand Down Expand Up @@ -84,7 +84,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
authentication:
Expand Down Expand Up @@ -114,7 +114,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
authorization:
Expand All @@ -139,7 +139,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
authorization:
Expand Down
1 change: 1 addition & 0 deletions docs/modules/kafka/partials/supported-versions.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
- 3.1.0
- 3.2.0
- 3.3.1
- 3.4.0
2 changes: 1 addition & 1 deletion examples/logging/simple-kafka-cluster-opa-log4j.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
authorization:
Expand Down
2 changes: 1 addition & 1 deletion examples/opa/simple-kafka-cluster-opa-allow-all.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
authorization:
Expand Down
2 changes: 1 addition & 1 deletion examples/tls/simple-kafka-cluster-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ metadata:
name: simple-kafka
spec:
image:
productVersion: 3.3.1
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
authentication:
Expand Down
8 changes: 4 additions & 4 deletions rust/crd/src/affinity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
zookeeperConfigMapName: xyz
brokers:
Expand Down Expand Up @@ -104,8 +104,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
zookeeperConfigMapName: xyz
brokers:
Expand Down
28 changes: 14 additions & 14 deletions rust/crd/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
zookeeperConfigMapName: xyz
"#;
Expand All @@ -469,8 +469,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
tls:
serverSecretClass: simple-kafka-server-tls
Expand All @@ -494,8 +494,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
tls:
serverSecretClass: null
Expand All @@ -515,8 +515,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
zookeeperConfigMapName: xyz
clusterConfig:
tls:
Expand All @@ -540,8 +540,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
zookeeperConfigMapName: xyz
"#;
Expand All @@ -559,8 +559,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
tls:
internalSecretClass: simple-kafka-internal-tls
Expand All @@ -580,8 +580,8 @@ mod tests {
name: simple-kafka
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
tls:
serverSecretClass: simple-kafka-server-tls
Expand Down
12 changes: 6 additions & 6 deletions rust/crd/src/listener.rs
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,8 @@ mod tests {
namespace: default
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
authentication:
- authenticationClass: kafka-client-tls
Expand Down Expand Up @@ -285,8 +285,8 @@ mod tests {
namespace: default
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
clusterConfig:
tls:
serverSecretClass: tls
Expand Down Expand Up @@ -345,8 +345,8 @@ mod tests {
namespace: default
spec:
image:
productVersion: 3.3.1
stackableVersion: "23.4.0-rc2"
productVersion: 3.4.0
stackableVersion: "0.0.0-dev"
zookeeperConfigMapName: xyz
clusterConfig:
tls:
Expand Down
5 changes: 4 additions & 1 deletion rust/operator/src/kafka_controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,10 @@ fn build_broker_rolegroup_statefulset(
..EnvVar::default()
});

let jvm_args = format!("-javaagent:/stackable/jmx/jmx_prometheus_javaagent-0.16.1.jar={}:/stackable/jmx/broker.yaml", METRICS_PORT);
let jvm_args = format!(
"-javaagent:/stackable/jmx/jmx_prometheus_javaagent.jar={}:/stackable/jmx/broker.yaml",
METRICS_PORT
);
let kafka_listeners =
get_kafka_listener_config(kafka, kafka_security, &rolegroup_ref.object_name())
.context(InvalidKafkaListenersSnafu)?;
Expand Down
7 changes: 4 additions & 3 deletions tests/test-definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ dimensions:
- 3.1.0-stackable0.0.0-dev
- 3.2.0-stackable0.0.0-dev
- 3.3.1-stackable0.0.0-dev
- 3.4.0-stackable0.0.0-dev
- name: kafka-latest
values:
- 3.3.1-stackable0.0.0-dev
- 3.4.0-stackable0.0.0-dev
- name: zookeeper
values:
- 3.6.3-stackable0.0.0-dev
Expand All @@ -24,11 +25,11 @@ dimensions:
- name: upgrade_old
values:
- 2.8.1-stackable0.0.0-dev
- 3.1.0-stackable0.0.0-dev
- 3.2.0-stackable0.0.0-dev
- 3.3.1-stackable0.0.0-dev
- name: upgrade_new
values:
- 3.3.1-stackable0.0.0-dev
- 3.4.0-stackable0.0.0-dev
- name: use-client-tls
values:
- "true"
Expand Down

0 comments on commit 87c5c5a

Please sign in to comment.