-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix upgrade path 3.3.x -> 4.0.x #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Btw, you can add a |
3aafd2b
to
6a09616
Compare
Co-authored-by: Xenia Fischer <[email protected]>
6a09616
to
41809f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the upgrade test
All tests passed |
Description
Fixes #538
This PR also adds an upgrade test to make sure the functionality will be kept going forward.
Co-developed with @xeniape
Definition of Done Checklist
Author
Reviewer
Acceptance