Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include hdfs principal names in discovery ConfigMap #451

Merged
merged 4 commits into from
Jan 12, 2024
Merged

fix: Include hdfs principal names in discovery ConfigMap #451

merged 4 commits into from
Jan 12, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 9, 2024 •
edited by lfrancke
Loading

Description

Replaces #424
Fixes #419

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer self-assigned this Jan 9, 2024
@sbernauer sbernauer mentioned this pull request Jan 9, 2024
Closed
@siegfriedweber siegfriedweber self-requested a review January 10, 2024 08:33
siegfriedweber
siegfriedweber requested changes Jan 11, 2024
View reviewed changes
docs/modules/hdfs/pages/reference/discovery.adoc Outdated Show resolved Hide resolved
docs/modules/hdfs/pages/reference/discovery.adoc Outdated Show resolved Hide resolved
docs/modules/hdfs/pages/reference/discovery.adoc Outdated Show resolved Hide resolved
docs/modules/hdfs/pages/reference/discovery.adoc Outdated Show resolved Hide resolved
rust/operator-binary/src/discovery.rs Show resolved Hide resolved
rust/operator-binary/src/kerberos.rs Show resolved Hide resolved
siegfriedweber
siegfriedweber approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member Author

Thanks for the review!

@sbernauer sbernauer added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 1e4f5a2 Jan 12, 2024
30 checks passed
@sbernauer sbernauer deleted the fix/kerberos-discovery-2 branch January 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi left review comments

@NickLarsenNZ NickLarsenNZ NickLarsenNZ left review comments

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@sbernauer sbernauer

Labels
release/2024-03
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discovery configmap incomplete when Kerberos is enabled
5 participants
@sbernauer @NickLarsenNZ @Techassi @siegfriedweber @lfrancke