Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support PodDisruptionBudgets #394

Merged
merged 32 commits into from
Sep 26, 2023
Merged

feat: Support PodDisruptionBudgets #394

merged 32 commits into from
Sep 26, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 19, 2023

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Cargo.toml Outdated Show resolved Hide resolved
@sbernauer sbernauer marked this pull request as ready for review September 21, 2023 11:22
@sbernauer
Copy link
Member Author

@sbernauer sbernauer self-assigned this Sep 21, 2023
@sbernauer sbernauer force-pushed the feat/support-pdb branch 2 times, most recently from b2a4a76 to 011f028 Compare September 21, 2023 13:23
@sbernauer sbernauer force-pushed the feat/support-pdb branch 2 times, most recently from 871c2c1 to 0b6e7da Compare September 21, 2023 13:25
@sbernauer sbernauer requested a review from lfrancke September 22, 2023 06:48
@lfrancke
Copy link
Member

I want to wait for a second opinion but it's a minor thing and otherwise good to go (I only looked at the docs!)

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @lfrancke any more input?

@sbernauer sbernauer enabled auto-merge September 26, 2023 09:15
@sbernauer sbernauer disabled auto-merge September 26, 2023 09:16
@sbernauer
Copy link
Member Author

@lfrancke
Copy link
Member

No. I looked at the docs and am fine with that bit

@sbernauer
Copy link
Member Author

Could you please approve so that we can merge? :)

@sbernauer sbernauer enabled auto-merge September 26, 2023 11:02
@sbernauer sbernauer requested review from lfrancke and removed request for lfrancke September 26, 2023 11:02
@sbernauer sbernauer added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit fabdf58 Sep 26, 2023
@sbernauer sbernauer deleted the feat/support-pdb branch September 26, 2023 11:17
@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. changelog/crd-change release/2023-11 labels Sep 27, 2023
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2023-11 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants