-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support PodDisruptionBudgets #394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
commented
Sep 19, 2023
sbernauer
force-pushed
the
feat/support-pdb
branch
from
September 21, 2023 13:09
fcb72bf
to
f50edae
Compare
sbernauer
force-pushed
the
feat/support-pdb
branch
2 times, most recently
from
September 21, 2023 13:23
b2a4a76
to
011f028
Compare
sbernauer
force-pushed
the
feat/support-pdb
branch
2 times, most recently
from
September 21, 2023 13:25
871c2c1
to
0b6e7da
Compare
sbernauer
force-pushed
the
feat/support-pdb
branch
from
September 21, 2023 13:26
0b6e7da
to
58d6d42
Compare
lfrancke
requested changes
Sep 21, 2023
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hdfs/pages/usage-guide/operations/pod_disruptions.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Lars Francke <[email protected]>
I want to wait for a second opinion but it's a minor thing and otherwise good to go (I only looked at the docs!) |
sbernauer
force-pushed
the
feat/support-pdb
branch
from
September 26, 2023 08:07
ad2142a
to
35fcdd9
Compare
maltesander
reviewed
Sep 26, 2023
sbernauer
force-pushed
the
feat/support-pdb
branch
from
September 26, 2023 08:58
2c10118
to
bcaebc6
Compare
maltesander
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @lfrancke any more input?
No. I looked at the docs and am fine with that bit |
Could you please approve so that we can merge? :) |
lfrancke
approved these changes
Sep 26, 2023
lfrancke
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
changelog/crd-change
release/2023-11
labels
Sep 27, 2023
lfrancke
added
the
release-note/action-required
Denotes a PR that introduces potentially breaking changes that require user action.
label
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release/2023-11
release-note/action-required
Denotes a PR that introduces potentially breaking changes that require user action.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#435
Definition of Done Checklist
Author
Reviewer
Acceptance