feat(regionserver): add graceful shutdown configuration #570
Conversation
Extract region configuration into it's own structure. Refactor the lib and controller modules to work with the new structure in a slightly generic way.
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc
Outdated
Show resolved
Hide resolved
| extraOpts: ["--designatedFile", "/path/to/designatedFile"] <4> | ||
| ---- | ||
| <1>: Run the region mover tool before shutting down the region server. Default is `false`. | ||
| <2>: Maximum number of threads to use for moving regions. Default is 1. |
There was a problem hiding this comment.
Is there a hint how this value should be set? Eg: number of servers?
There was a problem hiding this comment.
I suppose it depends on the number of regions, servers to distribute the regions to, total row count and what not.
As usual : it's complicated and if you don't have performance problems, don't touch it!
"1" is the default region mover it's self uses.
There was a problem hiding this comment.
In any case, there probably should be some guidance rather than leaving it ambiguous.
There was a problem hiding this comment.
I'll have to defer to the experts then.
| <1>: Run the region mover tool before shutting down the region server. Default is `false`. | ||
| <2>: Maximum number of threads to use for moving regions. Default is 1. | ||
| <3>: Enable or disable region confirmation on the present and target servers. Default is `true`. | ||
| <4>: Extra options to pass to the region mover tool. |
There was a problem hiding this comment.
Maybe add a link to valid options (or maybe they're covered already?)
There was a problem hiding this comment.
I couldn't find any documentation on this tool. I used the source.
There was a problem hiding this comment.
Maybe we ca give a hint where to find the extra options in the source code?
…own.adoc Co-authored-by: Nick <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Not disagreeing, but what is the benefit against just implementing Merge for it (as it's already done) ? It seems to me like a lot more (quirky) code would be needed to achieve the same thing. |
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc
Outdated
Show resolved
Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Siegfried Weber <[email protected]>
Co-authored-by: Siegfried Weber <[email protected]>
Co-authored-by: Siegfried Weber <[email protected]>
…own.adoc Co-authored-by: Siegfried Weber <[email protected]>
…own.adoc Co-authored-by: Siegfried Weber <[email protected]>
…own.adoc Co-authored-by: Siegfried Weber <[email protected]>
…own.adoc Co-authored-by: Siegfried Weber <[email protected]>
Co-authored-by: Siegfried Weber <[email protected]>
Description
part of: #508
requires: stackabletech/docker-images#898
Implementation for "approach B" in https://github.com/stackabletech/decisions/issues/30
Definition of Done Checklist
Author
Reviewer
Acceptance