Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support graceful shutdown #402

Merged
merged 26 commits into from
Nov 2, 2023
Merged

feat: Support graceful shutdown #402

merged 26 commits into from
Nov 2, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 11, 2023 •
edited
Loading

Description

Part of stackabletech/issues#357
Closes #400

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

Techassi
Techassi requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/hbase_controller.rs Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

Please have a look at 5a27400 and stackabletech/hdfs-operator@153b2c2

@sbernauer sbernauer requested a review from Techassi October 19, 2023 13:16
Techassi
Techassi requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nit :)

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer requested a review from Techassi October 19, 2023 13:48
@sbernauer
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/107/

Techassi
Techassi previously approved these changes Oct 19, 2023
View reviewed changes
siegfriedweber
siegfriedweber previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member Author

Final test run: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/110/

@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/job/hbase-operator-it-custom/111/

@sbernauer
Copy link
Member Author

Tests passed 🚀

@sbernauer sbernauer added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 809e3b6 Nov 2, 2023
29 checks passed
@sbernauer sbernauer deleted the feat/graceful-shutdown branch November 2, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

@siegfriedweber siegfriedweber siegfriedweber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support graceful shutdown
4 participants
@sbernauer @Techassi @siegfriedweber @Jimvin