Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concepts guide on graceful shutdown #468

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Add concepts guide on graceful shutdown #468

merged 5 commits into from
Oct 11, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 10, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit fbdd710
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/652676b572a1b20008b1fcd0
😎 Deploy Preview https://deploy-preview-468--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sbernauer sbernauer mentioned this pull request Oct 10, 2023
Closed
@adwk67 adwk67 self-requested a review October 10, 2023 10:16
@sbernauer @adwk67
Apply suggestions from code review
e812685 
Co-authored-by: Andrew Kenworthy <[email protected]>
@sbernauer sbernauer requested a review from adwk67 October 10, 2023 11:03
@sbernauer @adwk67
Apply suggestions from code review
b4af463 
Co-authored-by: Andrew Kenworthy <[email protected]>
@sbernauer sbernauer requested a review from adwk67 October 10, 2023 11:32
adwk67
adwk67 previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

Thanks for the review!

@sbernauer sbernauer self-assigned this Oct 10, 2023
@sbernauer sbernauer requested a review from adwk67 October 11, 2023 10:19
@sbernauer sbernauer enabled auto-merge October 11, 2023 10:19
@sbernauer sbernauer added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit e7be753 Oct 11, 2023
4 checks passed
@sbernauer sbernauer deleted the concepts-graceful-shutdown branch October 11, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@sbernauer sbernauer

Labels
release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @adwk67 @lfrancke