emit new peer notification without holding the semaphore

sstanculeanu · Jul 13, 2021 · 861bb84 · 861bb84
1 parent ac4a401
commit 861bb84
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/notify.go b/notify.go
@@ -24,15 +24,13 @@ func (p *PubSubNotif) Connected(n network.Network, c network.Conn) {
 
 	select {
 	case <-p.newPeersSema:
-		defer func() {
-			p.newPeersSema <- struct{}{}
-		}()
-
 	case <-p.ctx.Done():
 		return
 	}
 
 	p.newPeersPend[c.RemotePeer()] = struct{}{}
+	p.newPeersSema <- struct{}{}
+
 	select {
 	case p.newPeers <- struct{}{}:
 	default:
@@ -61,10 +59,6 @@ func (p *PubSubNotif) Initialize() {
 
 	select {
 	case <-p.newPeersSema:
-		defer func() {
-			p.newPeersSema <- struct{}{}
-		}()
-
 	case <-p.ctx.Done():
 		return
 	}
@@ -76,6 +70,8 @@ func (p *PubSubNotif) Initialize() {
 		p.newPeersPend[pid] = struct{}{}
 	}
 
+	p.newPeersSema <- struct{}{}
+
 	select {
 	case p.newPeers <- struct{}{}:
 	default: