Fix Memory Leak In New Timecache Implementations (libp2p#528)

* fix bug * add for last seen cache
sstanculeanu · Mar 15, 2023 · 340387e · 340387e
1 parent 829f902
commit 340387e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/timecache/first_seen_cache_test.go b/timecache/first_seen_cache_test.go
@@ -26,8 +26,10 @@ func TestFirstSeenCacheExpire(t *testing.T) {
 	}
 
 	time.Sleep(2 * time.Second)
-	if tc.Has(fmt.Sprint(0)) {
-		t.Fatal("should have dropped this from the cache already")
+	for i := 0; i < 10; i++ {
+		if tc.Has(fmt.Sprint(i)) {
+			t.Fatalf("should have dropped this key: %s from the cache already", fmt.Sprint(i))
+		}
 	}
 }
 

diff --git a/timecache/last_seen_cache_test.go b/timecache/last_seen_cache_test.go
@@ -25,8 +25,10 @@ func TestLastSeenCacheExpire(t *testing.T) {
 	}
 
 	time.Sleep(2 * time.Second)
-	if tc.Has(fmt.Sprint(0)) {
-		t.Fatal("should have dropped this from the cache already")
+	for i := 0; i < 11; i++ {
+		if tc.Has(fmt.Sprint(i)) {
+			t.Fatalf("should have dropped this key: %s from the cache already", fmt.Sprint(i))
+		}
 	}
 }
 

diff --git a/timecache/util.go b/timecache/util.go
@@ -9,7 +9,7 @@ import (
 var backgroundSweepInterval = time.Minute
 
 func background(ctx context.Context, lk sync.Locker, m map[string]time.Time) {
-	ticker := time.NewTimer(backgroundSweepInterval)
+	ticker := time.NewTicker(backgroundSweepInterval)
 	defer ticker.Stop()
 
 	for {