Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getGroupTangle #3

Merged
merged 19 commits into from
Oct 7, 2022
Merged

Add getGroupTangle #3

merged 19 commits into from
Oct 7, 2022

Conversation

Powersource
Copy link
Collaborator

@Powersource Powersource commented Sep 28, 2022

based on #2

We need this to add correct group tangles to group messages

  • probably combine addGroupTangle and create into a function with better dx, that we then probably expose in the top level api

@Powersource Powersource marked this pull request as ready for review October 6, 2022 12:03
@Powersource Powersource requested review from staltz and mixmix October 6, 2022 12:03
@arj03
Copy link
Member

arj03 commented Oct 6, 2022

It would be good with a test of how this performs if you have 10.000 messages in a group

@staltz
Copy link
Member

staltz commented Oct 6, 2022

@arj03 Could perf be studied and optimized in a different PR?

@arj03
Copy link
Member

arj03 commented Oct 6, 2022

Yes, its just so that we:

  1. know how it performs in realistic settings
  2. can use this as a baseline for optimizations (and make sure we don't make things slower :-))

test/helpers/testbot.js Outdated Show resolved Hide resolved
test/helpers/testbot.js Outdated Show resolved Hide resolved
test/get-group-tangle.test.js Outdated Show resolved Hide resolved
test/get-group-tangle.test.js Outdated Show resolved Hide resolved
test/get-group-tangle.test.js Outdated Show resolved Hide resolved
lib/get-group-tangle.js Outdated Show resolved Hide resolved
lib/get-group-tangle.js Outdated Show resolved Hide resolved
lib/get-group-tangle.js Outdated Show resolved Hide resolved
lib/get-group-tangle.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@Powersource Powersource requested a review from staltz October 7, 2022 12:23
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@Powersource Powersource merged commit 2b740c7 into master Oct 7, 2022
@Powersource Powersource deleted the get-group-tangle branch October 7, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants