Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP notes #20

Closed
wants to merge 2 commits into from
Closed

WIP notes #20

wants to merge 2 commits into from

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented Mar 8, 2023

I'm only half way through. This is a mishmash of notes as I go, suggestions, questions.

My major question is around the definition of common at the moment.
I may keep reading to see if it resolves itself but have run out of steam today

@mixmix mixmix requested a review from staltz March 8, 2023 04:33
```
common(G,H) = members(G) ∩ members(nearest(G,H))
```
> TODO - this definition doesn't take into account additions between `common(G, H)` and `H`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I'm confused by

Copy link
Member

@staltz staltz Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, "common" is not "intersection". What this definition captures is the set of "remaining" members. If there is a bifurcation in the epochs, we need to go back to the common predecessor, look at its members, and see what those members have to do regarding the bifurcation. They are the ones who witnessed the bifurcation happening, and they have data that helps them decide which fork to select as the most preferred.

The reason this doesn't work as

common(G,H) = members(G) ∩ members(H)

is because common(G,H) = common(H,G) is always true, which means rule 4.4. is always applied. Also common(L,R) ⊂ common(R,L) is never true, which means rule 4.5. is never applied. And common(L,R) △ common(R,L) is always empty, which means rule 4.6. is never applied.

So this means we only have rule 4.4., which says to only use tie-breaking rule to select the preferred epoch. This doesn't work in some cases, see e.g.

graph TB;
  zero[X: a,b,c,d]
  zero--"b excludes d"-->L[L: a,b,c]
  zero--"a excludes c,d"-->R[R: a,b]
Loading

Suppose L is the tie-breaking winner. Then a and b decide to go to L, where c is, but a doesn't want c in the group! Do they have to re-remove c? And who performs that action? a or b? If it's both, then you may end up with forks again.

The case above may seem simple to fix: we just have to make 4.5. be the rule members(L) ⊂ members(R) instead of common(L,R) ⊂ common(R,L), but then we are incorrectly taking into consideration members that were freshly added to either side. Those fresh members kind of don't matter when it comes to choosing forks. We want to know what is the forked epoch that has most excluded members, and jump to that one, but we can only talk about exclusions if we refer to the original (thus the common predecessor) context.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in another PR

README.md Show resolved Hide resolved

It is RECOMMENDED that epoch `G` is the "most preferred epoch" among all the
epochs that `a` is a member of, which succeed a certain epoch zero.
> - TODO what is the `tangles.group` + `tangles.member` for these `group/add-member`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we pin down the tangles right, we can do really tidy quick lookups for the memberships of each epoch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this #17

README.md Outdated
@@ -184,6 +190,7 @@ Section 3.2.2.
* 4.1.3. `a` MUST publish a `group/init` message on `Ha`, as described in the
[private-group-spec], with the exception that:
* 4.1.3.A. the `tangles.group.previous` field MUST be epoch `G`'s ID, and
> - TODO what's the ID? is it the previous `group/init` message id, or a cloakedId, or ...?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@staltz
Copy link
Member

staltz commented Mar 8, 2023

Would be nice if you could extract some of the consensus snippets that we arrived in the discussions above, and make each a PR.

@mixmix
Copy link
Member Author

mixmix commented Mar 15, 2023

We could use subscripts which might read easier ... test:

Ga

@mixmix
Copy link
Member Author

mixmix commented Mar 19, 2023

This WIP notes PR has now been fully superceeded by children

@mixmix mixmix closed this Mar 19, 2023
@mixmix mixmix deleted the mixmix branch March 19, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants