Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tangle exceptions from group/init #16

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Remove tangle exceptions from group/init #16

merged 1 commit into from
Mar 10, 2023

Conversation

Powersource
Copy link
Contributor

Fixes #11
Fixes #12

@Powersource
Copy link
Contributor Author

This should be followed up by a different PR in private-group-spec specifying how the group and epoch tangles should work on group/epoch init msgs.

@Powersource
Copy link
Contributor Author

Made issue for the followup #17

@Powersource Powersource requested a review from staltz February 24, 2023 14:49
@Powersource
Copy link
Contributor Author

@mixmix @staltz

staltz
staltz approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@Powersource Powersource merged commit 6dfd84b into master Mar 10, 2023
@Powersource Powersource deleted the Powersource-patch-1 branch March 10, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group.root can only be null at the root itself group.previous should always point at latest messages
2 participants
@Powersource @staltz