Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start to adapt to multiple epochs #27

Merged
merged 8 commits into from
Mar 7, 2023
Merged

Start to adapt to multiple epochs #27

merged 8 commits into from
Mar 7, 2023

Conversation

Powersource
Copy link
Collaborator

@Powersource Powersource commented Feb 24, 2023 •
edited
Loading

For ssbc/ssb-tribes2#65

  • can the user add multiple keys to a group? test
  • if not, add that functionality
  • rename getGroupKeyInfo
  • add function for picking write key for a group
  • test pick function
  • update readme. remember keyring changes bubbling up. pick function. getGroupInfo

Powersource
Powersource commented Feb 24, 2023
View reviewed changes
format.js Outdated Show resolved Hide resolved
@Powersource Powersource mentioned this pull request Feb 24, 2023
Merged
10 tasks
@Powersource
Copy link
Collaborator Author

https://gitlab.com/ahau/lib/ssb-keyring/-/merge_requests/22

Powersource
Powersource commented Mar 3, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Powersource Powersource marked this pull request as ready for review March 7, 2023 11:53
@Powersource Powersource requested review from arj03, staltz and mixmix March 7, 2023 11:53
staltz
staltz approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the test and the readme in particular are nice.

@Powersource Powersource merged commit ee6b2e9 into master Mar 7, 2023
@Powersource Powersource deleted the epoch-keys branch March 7, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz approved these changes

@arj03 arj03 Awaiting requested review from arj03

@mixmix mixmix Awaiting requested review from mixmix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Powersource @staltz @arj03