add operator batch() #170
Merged
add operator batch() #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
commented
Aug 17, 2021
| @@ -396,9 +400,9 @@ function toPullStream() { | |||
| function paginateStream(ops) { | |||
| let seq = meta.seq || 0 | |||
| let total = Infinity | |||
| const limit = meta.pageSize || 1 | |||
| const limit = meta.pageSize || meta.batchSize || 20 | |||
There was a problem hiding this comment.
The default 1 was actually pretty bad for performance. Reminder: #123 (comment)
Benchmark results
|
arj03
approved these changes
Aug 18, 2021
Benchmark results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #167
Achieved in a non-breaking manner,
paginate()remains as it is, causing the final pull-stream to emit arrays of messages. We introducebatch()that has the same performance profile aspaginate(), but just configure how the results should be streamed: one message at a time, no array of messages.