Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable TestSpec #276

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Re-enable TestSpec #276

merged 2 commits into from
Dec 28, 2022

Conversation

KyleMaas
Copy link
Contributor

Doesn't actually appear to be broken, as long as you have envelope-spec downloaded like the test says. Hoping the CI system knows how to do that.

Fixes #275

See also #237

@KyleMaas
Copy link
Contributor Author

Apparently the CI system does not know how to download that, which is probably why it was failing.

@KyleMaas KyleMaas marked this pull request as draft December 23, 2022 02:13
@KyleMaas KyleMaas marked this pull request as ready for review December 23, 2022 02:28
@KyleMaas
Copy link
Contributor Author

A different test failed in that last CI run. Looks like this one worked. The failing test has been noted as #277, since that doesn't appear to be consistent.

So...what I did here was integrate the git clone command into the Makefile for make test. The reasons I did this rather than use a git submodule, and then clean it up after the test suite is done running, are:

  1. Submodules are a pain.
  2. This is only necessary for the one specific test. It's not relevant to building binaries or running anything other than the test suite.
  3. If the test is individually run, it tells the user what they need to do. So the only use case we really need to solve is the CI suite.

So, for those reasons, I feel that adding this into the Makefile is the most appropriate place for this.

@decentral1se decentral1se mentioned this pull request Dec 26, 2022
25 tasks
@KyleMaas
Copy link
Contributor Author

@decentral1se

This one should be ready for review when you have a chance. The test failure for the last commit was a different test than this one, and this one passed:

https://github.com/ssbc/go-ssb/actions/runs/3762663556/jobs/6395559642#step:9:196

Copy link
Member

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@decentral1se decentral1se merged commit 8a15e3d into ssbc:master Dec 28, 2022
@KyleMaas
Copy link
Contributor Author

Thanks!

@KyleMaas KyleMaas deleted the fix-test-spec branch December 28, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestSpec is not really flaky
2 participants