Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to fix TestNullFeed #269

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Attempting to fix TestNullFeed #269

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
664ef58
Add some comments
KyleMaas Dec 20, 2022
9a03418
Add a few more checks
KyleMaas Dec 20, 2022
09cc953
Check more things
KyleMaas Dec 21, 2022
7304d3a
More checking
KyleMaas Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 36 additions & 8 deletions sbot/null_feed_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ import (
)

func TestNullFeed(t *testing.T) {
if testutils.SkipOnCI(t) {
// https://github.com/ssbc/go-ssb/pull/170
return
}

defer leakcheck.Check(t)
ctx, cancel := context.WithCancel(context.TODO())
botgroup, ctx := errgroup.WithContext(ctx)
Expand Down Expand Up @@ -78,7 +73,7 @@ func TestNullFeed(t *testing.T) {
r.NoError(err)
botgroup.Go(bs.Serve(mainbot))

// create some messages
// create some messages under mainbot
intros := []struct {
as string // nick name
c interface{} // content
Expand Down Expand Up @@ -121,19 +116,30 @@ func TestNullFeed(t *testing.T) {
checkLogSeq(l, seq)
}

// make sure mainbot logged all of our initial test messages
checkLogSeq(mainbot.ReceiveLog, len(intros)-1) // got all the messages

// check before drop
checkUserLogSeq(mainbot, "arny", 1)
checkUserLogSeq(mainbot, "bert", 2)

// fsck mainbot before NullFeed so if it fails afterward we know it happened within NullFeed
err = mainbot.FSCK(FSCKWithMode(FSCKModeSequences))
r.NoError(err)

// delete bert's feed from mainbot
err = mainbot.NullFeed(kpBert.ID())
r.NoError(err, "null feed bert failed")

// fsck mainbot to make sure NullFeed didn't mess something up
err = mainbot.FSCK(FSCKWithMode(FSCKModeSequences))
r.NoError(err)

// make sure we now have two messages for arny (follow and "hello") and none for bert
checkUserLogSeq(mainbot, "arny", 1)
checkUserLogSeq(mainbot, "bert", -1)

// start bert and publish some messages
// start an sbot for bert and publish some messages
bertBot, err := New(
WithKeyPair(kpBert),
WithInfo(kitlog.With(logger, "bot", "bert")),
Expand All @@ -145,25 +151,46 @@ func TestNullFeed(t *testing.T) {
r.NoError(err)
botgroup.Go(bs.Serve(bertBot))

// make main want it
// make main bot follow bert bot so it wants bert's messages
_, err = mainbot.PublishLog.Publish(refs.NewContactFollow(kpBert.ID()))
r.NoError(err)

// make bert bot follow main bot (this does not appear to be strictly necessary)
_, err = bertBot.PublishLog.Publish(refs.NewContactFollow(mainbot.KeyPair.ID()))
r.NoError(err)

// fsck both bots before we try to replicate
err = mainbot.FSCK(FSCKWithMode(FSCKModeSequences))
r.NoError(err)
err = bertBot.FSCK(FSCKWithMode(FSCKModeSequences))
r.NoError(err)

// start the replication processes
t.Log("starting replication")
mainbot.Replicate(bertBot.KeyPair.ID())
bertBot.Replicate(mainbot.KeyPair.ID())

// publish a bunch more test messages to bertbot so we can make sure they replicate correctly
const testMsgCount = 1000
for i := testMsgCount; i > 0; i-- {
_, err = bertBot.PublishLog.Publish(i)
r.NoError(err)
}
t.Log("done publishing messages")

// make sure bertbot's log actually reflects all of the messages + the follow message
checkUserLogSeq(bertBot, "bert", testMsgCount)

// make sure mainbot still doesn't have any bert messages
checkUserLogSeq(mainbot, "bert", -1)

// tell mainbot to connect to bertbot so it will replicate
t.Log("connecting")
err = mainbot.Network.Connect(context.TODO(), bertBot.Network.GetListenAddr())
r.NoError(err)

// register to be notified any time that mainbot receives a message about bert
// once we receive all of the messages, continue
gotMessage := make(chan struct{})
updateSink := luigi.FuncSink(func(ctx context.Context, v interface{}, err error) error {
seq, ok := v.(int64)
Expand All @@ -188,6 +215,7 @@ func TestNullFeed(t *testing.T) {
}
done()

// close things down
bertBot.Shutdown()
mainbot.Shutdown()

Expand Down