Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSubsetQueryPlanExecution is flaky #277

Closed
KyleMaas opened this issue Dec 23, 2022 · 1 comment · Fixed by #310
Closed

TestSubsetQueryPlanExecution is flaky #277

KyleMaas opened this issue Dec 23, 2022 · 1 comment · Fixed by #310
Labels
testing

Comments

@KyleMaas
Copy link
Contributor

See https://github.com/ssbc/go-ssb/actions/runs/3762663556/jobs/6395559642#step:9:210

Related to #237
@KyleMaas KyleMaas mentioned this issue Dec 23, 2022
Merged
@decentral1se decentral1se mentioned this issue Dec 26, 2022
Open
25 tasks
@decentral1se decentral1se moved this from In Progress to TODO in 🚧 go-ssb maintenance 🚧 Jan 10, 2023
@decentral1se decentral1se moved this from TODO to Prioritised in 🚧 go-ssb maintenance 🚧 Jan 10, 2023
@KyleMaas
Copy link
Contributor Author

Okay, so this comes from here:

go-ssb/query/subsetquery_test.go

Line 202 in d429bd0

msgs, err := sp.QuerySubsetMessages(mainbot.ReceiveLog, query.NewSubsetOpByAuthor(kpArny.ID()))

And to dive deeper, this comes from here:

https://github.com/ssbc/margaret/blob/22ed48add4909da6153dfc3c1ed82642efd9c225/multilog/roaring/multilog.go#L150

It looks to me like what's happening is it's proceeding to try to pull from the index before the messages have finished indexing. So we need it to wait for indexing to complete.

@KyleMaas KyleMaas mentioned this issue Jan 28, 2023
Merged
@github-project-automation github-project-automation bot moved this from Prioritised to Done in 🚧 go-ssb maintenance 🚧 Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
🚧 go-ssb maintenance 🚧
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TestSubsetQueryPlanExecution KyleMaas/go-ssb
2 participants
@decentral1se @KyleMaas