Add version of Pump() with status callbacks #4
Conversation
|
@cryptix Thanks for the feedback! Not sure I can answer that question - I just copied it from the other version, so if it needs to be removed, it probably needs to be removed from both. |
|
I don't have the time to do a full scan for this but a cursory look just turned up two, probably also outdated, utilities in go-ssb that actually use PushSource. So it might be fine to replace and will probably help to reduce luigi's surface area for a future replacment anyway. I would have expected margaret or go-ssb's indexes to use this at least. Or it could have been for go-muxrpc, which used luigi before I ditched it there in v2. context: Not sure how familiar you are with Go's stdlib interfaces but Pump is akin to io.Copy and PushSource was intended as something like WriteTo. Back then we were way to ignorant about the use of |
|
So are we good to merge this, then, and try and tackle removing PushSource in a subsequent pull request against both projects? |
|
PushSource follow ups are #5 / ssbc/go-ssb#304 |
|
Awesome. Thanks! |
This adds a version of the
Pump()function which takes callback functions so the caller knows where we're at in the processing cycle.This came up while seeking a solution for ssbc/go-ssb#251. Since the Luigi
Pump()s were all being run in goroutines, we had no way to know if the indexes had caught up with the main log to know whether or not they're in sync, which caused all kinds of problems. This gives us a very easy way to fix that.