Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #49

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Minor fixes #49

merged 2 commits into from
Sep 7, 2021

Conversation

arj03
Copy link
Member

@arj03 arj03 commented Sep 6, 2021

While working on ssbc/ssb-ebt#52 and refactoring things out to be more modular I discovered two issues:

  1. _validate is never used
  2. there were some old tests still testing for now unsupported version 2

@arj03 arj03 requested a review from staltz September 6, 2021 09:04
@arj03 arj03 mentioned this pull request Sep 6, 2021
Closed
@arj03
Copy link
Member Author

arj03 commented Sep 7, 2021

Thanks :)

@arj03 arj03 merged commit 8e26f64 into master Sep 7, 2021
@arj03 arj03 deleted the minor-fixes branch September 7, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arj03 @staltz