Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance palettes for color blindness impairment #302

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Enhance palettes for color blindness impairment #302

merged 1 commit into from
Oct 18, 2019

Conversation

dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Oct 17, 2019 •
edited
Loading

fix #301

This PR only modifies srcdMain and srcdSix current palettes in order to make them accessible for color blindness impairment. It can be seen in the left chart below.

image

The example at the right just shows how would it look like if #303 is approved

  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

@dpordomingo dpordomingo added enhancement New feature or request blocked This is blocked for some reason labels Oct 17, 2019
@dpordomingo dpordomingo self-assigned this Oct 17, 2019
@dpordomingo
Copy link
Contributor Author

I guessed the new color specs using the color picker from Gimp over the proposed color palette image.
Could you please @ricardobaeta confirm the colors?

@ricardobaeta
Copy link
Contributor

@dpordomingo the new secondary colors are:

image

#00d6d1 & #00eae4 ~~~ #05d600 & #05ea00 ~~~ #3d3d3d & #565656

@dpordomingo dpordomingo removed the blocked This is blocked for some reason label Oct 17, 2019
@dpordomingo
Copy link
Contributor Author

This is ready for your final review @ricardobaeta

@dpordomingo dpordomingo mentioned this pull request Oct 17, 2019
Closed
@dpordomingo dpordomingo requested a review from a team October 17, 2019 17:35
se7entyse7en
se7entyse7en approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@se7entyse7en se7entyse7en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once @ricardobaeta approves feel free to merge this.

@ricardobaeta
Copy link
Contributor

@dpordomingo We have now achieved a fair compromise on accessibility for people with Color Blindness Impairment. Great work!

No Color Blindness Impairment

image

Color Blindness Impairment

image

ricardobaeta
ricardobaeta approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@ricardobaeta ricardobaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dpordomingo dpordomingo mentioned this pull request Oct 17, 2019
Open
2 tasks
@dpordomingo dpordomingo merged commit 5cc50c4 into src-d:master Oct 18, 2019
@dpordomingo dpordomingo deleted the color-blindness branch October 18, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@se7entyse7en se7entyse7en se7entyse7en approved these changes

@ricardobaeta ricardobaeta ricardobaeta approved these changes

Assignees

@dpordomingo dpordomingo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance palettes for color blindness impairment
3 participants
@dpordomingo @ricardobaeta @se7entyse7en