Skip to content

Commit

Permalink
Polish Makefile removing unused target 'patch-dev'
Browse files Browse the repository at this point in the history
Since 'make patch-dev' is no longer needed, we can get rid of it, and
also delete 'srcd/superset/superset_config_dev.py'

Signed-off-by: David Pordomingo <[email protected]>
  • Loading branch information
dpordomingo committed Jul 17, 2019
1 parent f8a1794 commit bf031f3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
11 changes: 0 additions & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,6 @@ patch: clean apply-patch
apply-patch:
cp -r $(PATCH_SOURCE_DIR)/* $(SUPERSET_DIR)/

# Copy src-d files in the superset repository using symlinks. it's useful for development.
# Allows to run flask locally and work only inside superset directory.
.PHONY: patch-dev
patch-dev: clean
@diff=`diff -r $(PATCH_SOURCE_DIR) $(SUPERSET_DIR) | grep "$(PATCH_SOURCE_DIR)" | awk '{gsub(/: /,"/");print $$3}'`; \
for file in $${diff}; do \
to=`echo $${file} | cut -d'/' -f2-`; \
ln -s "$(PWD)/$${file}" "$(SUPERSET_DIR)/$${to}"; \
done; \
ln -s "$(PWD)/$(PATCH_SOURCE_DIR)/superset/superset_config_dev.py" "$(SUPERSET_DIR)/superset_config.py"; \

# Start a watcher that will run 'make apply-patch' automatically when 'srcd' changes
# It will require either inotify or fswatch. More info in CONTRIBUTING.md
.PHONY: watch
Expand Down
11 changes: 0 additions & 11 deletions srcd/superset/superset_config_dev.py

This file was deleted.

0 comments on commit bf031f3

Please sign in to comment.