Revert last GitBook commit #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9cdd13. And also keeps architecture, faq and troubleshooting in learn-more as it was suggested by GitBook edition Signed-off-by: David Pordomingo <[email protected]>
carlosms
approved these changes
Sep 11, 2019
dpordomingo
force-pushed
the
revert-gitbook-disaster
branch
from
5aea34e to
ff28f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required by #237
This PR reverts automatic changes done at c9cdd13 by @vcoisne.
Per later investigation, I confirmed that each edition made from GitBook UI (no matter what is edited) forces GitBook to parse the whole docs, and format them according to their internal (and not documented) rules.
Some uncontrolled changes, that were reverted in this PR are:
docs/CONTRIBUTING.mdbeing moved intodocs/learn-more/contributing.md,textinstead ofbashorpowershell,But this PR also modifies any other intentional change that could be done by @vcoisne at c9cdd13.
I tried to review the diff to find his edition, but I could not find any major change, so I wonder if the causing edition was a typo fix, or any other small change that I could not detect.
As discussed with @carlosms by slack, it would be better if we rollback the whole automatic commit, and re-do the intentional change again using the regular PullRequest flow, instead of using the GitBook UI, which is adding unexpected noise when reviewing PRs.