Add RateLimitTransport to the client.Transport chain

And enhance how the Transport are added

Signed-off-by: David Pordomingo <[email protected]>

examples/cmd/logtransport.go

@@ -10,8 +10,7 @@ import (
 )
 
 func setLogTransport(client *http.Client, logger log.Logger) {
-	t := &logTransport{client.Transport, logger}
-	client.Transport = t
+	client.Transport = &logTransport{client.Transport, logger}
 }
 
 type logTransport struct {

examples/cmd/main.go

@@ -270,6 +270,9 @@ func (c *DownloaderCmd) buildDownloadersPool(logger log.Logger, db *sql.DB) (*Do
 			setLogTransport(client, logger)
 		}
 
+		github.SetRateLimitTransport(client, logger)
+		github.SetRetryTransport(client)
+
 		var d *github.Downloader
 		var err error
 		if db == nil {

github/downloader.go

@@ -58,11 +58,6 @@ type Downloader struct {
 // in the given DB. The HTTP client is expected to have the proper
 // authentication setup
 func NewDownloader(httpClient *http.Client, db *sql.DB) (*Downloader, error) {
-	// TODO: is the ghsync rate limited client needed?
-
-	t := &retryTransport{httpClient.Transport}
-	httpClient.Transport = t
-
 	return &Downloader{
 		storer: &store.DB{DB: db},
 		client: githubv4.NewClient(httpClient),
@@ -73,11 +68,6 @@ func NewDownloader(httpClient *http.Client, db *sql.DB) (*Downloader, error) {
 // metadata to stdout. The HTTP client is expected to have the proper
 // authentication setup
 func NewStdoutDownloader(httpClient *http.Client) (*Downloader, error) {
-	// TODO: is the ghsync rate limited client needed?
-
-	t := &retryTransport{httpClient.Transport}
-	httpClient.Transport = t
-
 	return &Downloader{
 		storer: &store.Stdout{},
 		client: githubv4.NewClient(httpClient),