Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add tests everywhere #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Add tests everywhere #59

wants to merge 3 commits into from

Conversation

r0mainK
Copy link
Contributor

@r0mainK r0mainK commented Jun 15, 2018

#58

@r0mainK
Copy link
Contributor Author

r0mainK commented Jun 15, 2018

@vmarkovtsev tests failing because the version of sourced-ml package seems to be too outdated, compared to the git repo. We might wanna release a new one ? Else we can install it using git

@r0mainK r0mainK changed the title Fix and tests [WIP] [WIP] Add tests everywhere Jun 19, 2018
@r0mainK r0mainK changed the title [WIP] Add tests everywhere Add tests everywhere Jun 20, 2018
@r0mainK
Copy link
Contributor Author

r0mainK commented Jun 20, 2018

Wrote tests for as much stuff as possible. Currently bags, graph, main and cassandra_utils files are covered fully or almost. I want to add some for query, but regarding hash functions idk if Travis can handle all the GPU stuff. I also added a parameter to the Cassandra cluster because we often get connection timeouts with resetdb, from the logs i think it solves it for the most part.

@r0mainK r0mainK changed the title Add tests everywhere Add tests everywhere [WIP] Jun 20, 2018
@r0mainK r0mainK changed the title Add tests everywhere [WIP] [WIP] Add tests everywhere Jun 20, 2018
@r0mainK r0mainK changed the title [WIP] Add tests everywhere Add tests everywhere Jun 21, 2018
@r0mainK
Copy link
Contributor Author

r0mainK commented Jun 26, 2018

@vmarkovtsev let's merge this after #61 so I can modify/add tests for new ml and apollo features

@r0mainK r0mainK changed the title Add tests everywhere [TESTS] Add tests everywhere Jul 12, 2018
@r0mainK r0mainK changed the title [TESTS] Add tests everywhere [WUP] Add tests everywhere Sep 4, 2018
@r0mainK r0mainK changed the title [WUP] Add tests everywhere [WIP] Add tests everywhere Sep 4, 2018
@r0mainK
Copy link
Contributor Author

r0mainK commented Sep 4, 2018

Added Konst's changes from PR #66 so tests would not fail, will update the rest of the code asap

@vmarkovtsev
Copy link
Collaborator

#66 was merged

@r0mainK
Copy link
Contributor Author

r0mainK commented Sep 4, 2018

Great, will rebase and take care of conflicts asap. Ill also update the doc regarding the preprocess command

Signed-off-by: Romain Keramitas <[email protected]>
Signed-off-by: Romain Keramitas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants