Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add script for Windows (non-WSL) users + update readme #185

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

imhalcyon
Copy link
Contributor

Pull Request Title

Add script for Windows (non-WSL) users + update readme for webapp

Related Issue

#153

Description

The existing setup and instructions are not compatible for Windows (non-WSL) users.

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

  • Add scripts for Windows specific execution in package.json
  • Update readme file for webapp

Screenshots / Code Snippets (if applicable)

N/A

How to Test

  1. ReadMe file has been updated - follow steps according to your local workspace/machine

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

Also corrected a few typos in readme file

Copy link
Contributor

@Sayvai Sayvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor addition suggestions to the README. Good spot on the additional spelling mistakes (thanks 😅)

webapp/README.md Outdated Show resolved Hide resolved
webapp/README.md Outdated Show resolved Hide resolved
imhalcyon and others added 2 commits October 3, 2023 20:08
Add Mac OS as well

Co-authored-by: Sayvai <[email protected]>
Add Mac OS as well

Co-authored-by: Sayvai <[email protected]>
@imhalcyon
Copy link
Contributor Author

Just a couple of minor addition suggestions to the README. Good spot on the additional spelling mistakes (thanks 😅)

Forgot about Mac OS part - thanks for the suggestions! 😄

Copy link
Contributor

@Sayvai Sayvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thank you 🙌

@Sayvai
Copy link
Contributor

Sayvai commented Oct 3, 2023

Just a couple of minor addition suggestions to the README. Good spot on the additional spelling mistakes (thanks 😅)

Forgot about Mac OS part - thanks for the suggestions! 😄

Ha, no worries!

Now, only @srbhr have the privileges to merge into the base main branch. So it'll be up to him to merge these changes in when ready. He may also like to test this on his Windows machine too 😅

@srbhr srbhr merged commit 1418af1 into srbhr:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants