PSR2/PSR12/ControlStructureSpacing: don't listen for T_ELSE
#3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
T_ELSET_ELSE
No functional changes. These sniffs only concerns themselves with control structures which take parentheses, so listening for `T_ELSE` is unnecessary as the sniffs will never do anything for that token (they each bow out on no 'parenthesis_opener'/'parenthesis_closer' found).
jrfnl
force-pushed
the
feature/psr2-controlstructurespacing-remove-t_else
branch
from
1e26c73 to
33845b8
Compare
fredden
approved these changes
Aug 14, 2023
DannyvdSluijs
approved these changes
Aug 25, 2023
|
Since the changes have no effect (as it is a reduction of the tokens it wants to process) the verification is done by confirming the description of this PR is correct and secondly that the code changes are as expected. |
Merged
1 task
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No functional changes.
These sniffs only concern themselves with control structures which take parentheses, so listening for
T_ELSEis unnecessary as the sniffs will never do anything for that token (they each bow out on no 'parenthesis_opener'/'parenthesis_closer' found).Suggested changelog entry
N/A (no functional changes)
Types of changes