Generic/LowerCaseType: fix potential PHP notice #3833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Generic.PHP.LowerCaseType` sniff calls the `File::getMemberProperties()` method to get information about potential properties. That method throws an exception when the `T_VARIABLE` token passed is not a property, but will create an `Internal.ParseError.InterfaceHasMemberVar` warning and return an empty array when the `T_VARIABLE` passed is an _illegal_ property, i.e. a property in a context in which it is not allowed (interface/enum). As things were, the sniff did not take a potential return value of an empty array into account, which could result in an `Undefined array key "type"` PHP notice. Fixed now. Includes unit test.
|
This PR will conflict with PR #3662 and either one of them will need rebasing if the other gets merged first. |
5 tasks
2 tasks
This was referenced Nov 10, 2023
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#62 |
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Generic.PHP.LowerCaseTypesniff calls theFile::getMemberProperties()method to get information about potential properties.That method throws an exception when the
T_VARIABLEtoken passed is not a property, but will create anInternal.ParseError.InterfaceHasMemberVarwarning and return an empty array when theT_VARIABLEpassed is an illegal property, i.e. a property in a context in which it is not allowed (interface/enum).As things were, the sniff did not take a potential return value of an empty array into account, which could result in an
Undefined array key "type"PHP notice.Fixed now.
Includes unit test.
Suggested changelog entry
Generic.PHP.LowerCaseType: fixed potential undefined array index notice
Related issues/external references
N/A
Types of changes