Fixed instant navigation bugs #6662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This was referenced Jan 18, 2024
4 tasks
|
Sadly, we did not receive any feedback on this branch/PR, albeit it fixes all 6 open issues related to instant loading. However, we'll release it anyway so we don't clog our pipelines, and fix issues as we discover them. |
focustense
added a commit
to focustense/StardewUI
that referenced
this pull request
Oct 11, 2024
There is an issue where only the first anchor navigation works correctly, and subsequent ones always try to open in a new tab. There were reports that this was fixed, e.g. squidfunk/mkdocs-material#6662. However, it appears to have either regressed or not been fully tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a refactoring of instant navigation, trying to better orchestrate interception, fetching, parsing, as well as scroll restoration. It should also fix the following open bugs:
Test it with: