Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Lookup Fix #49

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Node Lookup Fix #49

merged 2 commits into from
Apr 16, 2024

Conversation

shaswot77
Copy link
Contributor

Description

  • Without the break the request was being made 10 times which is the maxRetries
  • Removed .order() as it fails if there are more than one object, and they appear to be un compareable

Checklist:

  • Added a label: bug-fix, feature, or enhancement
  • PR description written

@shaswot77 shaswot77 requested a review from P2P-Nathan April 16, 2024 13:33
P2P-Nathan
P2P-Nathan approved these changes Apr 16, 2024
View reviewed changes
Copy link

@P2P-Nathan P2P-Nathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix

@shaswot77 shaswot77 merged commit 37e6812 into main Apr 16, 2024
6 checks passed
@shaswot77 shaswot77 deleted the work/ss/node-lookup-loop branch April 16, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P2P-Nathan P2P-Nathan P2P-Nathan approved these changes

Assignees
No one assigned
Labels
bug-fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaswot77 @P2P-Nathan