fix(datetime)!: get day of week key without using locale

note that this removes the "locale" parameter from the param signature of several methods:
* helpers.datetime.getDayOfWeekKey
* helpers.location.getNextOpenIntervalAfterToday
* helpers.location.getOpenIntervalsForToday

src/helpers/datetime.ts

@@ -56,15 +56,15 @@ export const localizeDate = (dateObj: Date, locale: string, format: localizeDate
 
 /**
  * Gets the appropriate 3 letter key for the day of the week for a given date object
- * used to find the correct key of the hour data to pull data off of
+ * used to find the correct key of the hour data to pull data off of.
+ * We localize using the `en-US` locale, because the date keys are in that locale.
  *
  * @param {Date} dateObj
- * @param {locale} string - Hyphenized language/country locale combo, e.g. en-US (BCP 47).
  * @param {String} timezone
  * @return {DayOfWeek}
  */
-export const getDayOfWeekKey = (dateObj: Date, locale: string, timezone: string): DayOfWeek => {
-    const dayOfWeek = localizeDate(dateObj, locale,	DateFormats.weekdayShort, timezone);
+export const getDayOfWeekKey = (dateObj: Date, timezone: string): DayOfWeek => {
+    const dayOfWeek = localizeDate(dateObj, 'en-US', DateFormats.weekdayShort, timezone);
     return dayOfWeek.toUpperCase() as DayOfWeek;
 };
 

src/helpers/location.ts

@@ -118,7 +118,7 @@ export class Location {
             };
         }
 
-        const nextOpenIntervalAfterToday = this.getNextOpenIntervalAfterToday(locale, timezone, hours);
+        const nextOpenIntervalAfterToday = this.getNextOpenIntervalAfterToday(timezone, hours);
         if (nextOpenIntervalAfterToday) {
             const { date, interval: nextInterval } = nextOpenIntervalAfterToday;
             const opensAt = getFormattedTime(date, nextInterval.open, DateFormats.hourNminuteN, locale, timezone, tzOffsetString);
@@ -173,7 +173,6 @@ export class Location {
                 nextDateObj.setDate(nextDateObj.getDate() + 1);
                 const dayOfWeekKey = getDayOfWeekKey(
                     nextDateObj,
-                    locale,
                     timezone,
                 );
 
@@ -217,19 +216,16 @@ export class Location {
     /**
 	 * Gets open intervals for today
 	 *
-	 * @param {string} locale - Hyphenized language/country locale combo, e.g. en-US (BCP 47).
 	 * @param {string} timezone
 	 * @param {Hours} hours
 	 * @return {OpenInterval[]}
 	 */
     getOpenIntervalsForToday(
-        locale: string,
         timezone: string,
         hours: Hours
     ): OpenInterval[] {
         const dayOfWeekKey: DayOfWeek = getDayOfWeekKey(
             new Date(),
-            locale,
             timezone
         );
         return hours[dayOfWeekKey];
@@ -248,7 +244,7 @@ export class Location {
         timezone: string,
         hours: Hours
     ): OpenInterval | null {
-        const todayOpenIntervals = this.getOpenIntervalsForToday(locale, timezone, hours);
+        const todayOpenIntervals = this.getOpenIntervalsForToday(timezone, hours);
         if (!todayOpenIntervals.length) {
             return null;
         }
@@ -282,7 +278,7 @@ export class Location {
         timezone: string,
         hours: Hours
     ): OpenInterval | null {
-        const todayOpenIntervals = this.getOpenIntervalsForToday(locale, timezone, hours);
+        const todayOpenIntervals = this.getOpenIntervalsForToday(timezone, hours);
         if (!todayOpenIntervals.length) {
             return null;
         }
@@ -311,13 +307,11 @@ export class Location {
     /**
 	 * Get the next opening period after today within the next seven days
 	 *
-	 * @param {string} locale - Hyphenized language/country locale combo, e.g. en-US (BCP 47).
 	 * @param {string} timezone
 	 * @param {Hours} hours
 	 * @return {Object | null} { open: openTime, close: closeTime }
 	 */
     getNextOpenIntervalAfterToday(
-        locale: string,
         timezone: string,
         hours: Hours,
     ): {
@@ -331,7 +325,6 @@ export class Location {
             nextDateObj.setDate(nextDateObj.getDate() + 1);
             const dayOfWeekKey = getDayOfWeekKey(
                 nextDateObj,
-                locale,
                 timezone,
             );
 

test/helpers.location.test.ts

@@ -982,7 +982,6 @@ describe('Check open intervals for today', () => {
         vi.setSystemTime(date);
 
         const result = sdk.helpers.location.getOpenIntervalsForToday(
-            'en-US',
             'UTC',
             location['PICKUP'].hours
         );