Improve version specific executable searching. #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues testing v1 behavior while working on another pull request because the library couldn't find my v1 installation. I completely uninstalled AutoHotkey twice and tested two install configurations to see how it behaved and rewrote the executable searching code to accommodate it.
The first time I installed v1 then v2. In this case, v1 installed into
C:\Program Files\AutoHotkey
and v2 installed intoC:\Program Files\AutoHotkey\v2
.The second time I installed v2 then v1 (how I originally had it installed). In this case, v2 installed into
C:\Program Files\AutoHotkey\v2
and v1 installed intoC:\Program Files\AutoHotkey\v1.1.37.02
.So the rewritten code will search the top level install directory if v1 is selected, otherwise it will search for
v1...
orv2...
directories and then search there.I put all of the executables in a single list to save a line and an if statement but can split it if necessary.