-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect reST indents in docs #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked each case in the source and rendered output, and that all LGTM.
Could you (or I can, as a commit here) bump the Sphinx-Lint version to the latest 0.7.0 in the .pre-commit-config.yaml
so we're actually testing this against the latest Sphinx-Lint with all the checks, and don't have any regressions (which would in turn would make for problems with Sphinx-Lint's "friends" checker). Thanks!
Also, this is blocked on #352 being merged to fix the broken links detected by linkcheck, but I'll have that merged shortly and you can rebase (or merge) it in. Thanks!
(#352 is merged now, so this can be rebased or merged with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it was straightforward and we'd discussed it, I went ahead with updating the branch and bumping the Sphinx-Lint version and everything's green now, so this LGTM and should be good to merge. Thanks @ezio-melotti !
Pull Request
Pull Request Checklist
Description of Changes
Fixes markup errors spotted by:
cc @CAM-Gerlach
Issue(s) Resolved