-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CredentialPack to use ParsedCredential #39
Update CredentialPack to use ParsedCredential #39
Conversation
@Juliano1612 these |
Converted back to draft, IDE didn't immediately notify me of all the compilation errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
example/src/main/java/com/spruceid/mobilesdkexample/wallet/GenericCredentialListItem.kt
Outdated
Show resolved
Hide resolved
example/src/main/java/com/spruceid/mobilesdkexample/wallet/GenericCredentialListItem.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to merge.
I will add the addSdJwt
method for the cred pack in a follow up PR.
This implements only one button with a scanner that can handle: - External URLs: support QR Code with external URLs by redirecting the user to the browser - OID4VP URLs: redirects the user to the oid4vp flow - OID4VCI URLs: redirects the user to the oid4vci flow
Also remove
BaseCredential
,Mdoc
andW3CVC
types, and updated the demo app.