Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CredentialPack to use ParsedCredential #39

Merged

Conversation

cobward
Copy link
Contributor

@cobward cobward commented Oct 7, 2024

Also remove BaseCredential, Mdoc and W3CVC types, and updated the demo app.

@cobward
Copy link
Contributor Author

cobward commented Oct 7, 2024

@Juliano1612 these .idea file changes happened automatically when I opened the project in android-studio. Should I revert the changes and add the files to gitignore?

@cobward cobward marked this pull request as draft October 7, 2024 14:06
@cobward
Copy link
Contributor Author

cobward commented Oct 7, 2024

Converted back to draft, IDE didn't immediately notify me of all the compilation errors.

@cobward cobward marked this pull request as ready for review October 8, 2024 12:44
Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Ryanmtate Ryanmtate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge.

I will add the addSdJwt method for the cred pack in a follow up PR.

@Ryanmtate Ryanmtate merged commit 6b039d4 into main Oct 15, 2024
2 checks passed
@Ryanmtate Ryanmtate deleted the skit-573-update-credentialpack-to-use-parsedcredential-kotlin branch October 15, 2024 20:07
sprucekit-mobile-monorepo bot pushed a commit that referenced this pull request Nov 7, 2024
This implements only one button with a scanner that can handle:
- External URLs: support QR Code with external URLs by redirecting the user to the browser
- OID4VP URLs:  redirects the user to the oid4vp flow
- OID4VCI URLs: redirects the user to the oid4vci flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants