Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to lPop or rPop N elements from a Redis list in ReactiveListOperations #2704

Closed
wants to merge 2 commits into from
Closed

Add support to lPop or rPop N elements from a Redis list in ReactiveListOperations #2704

wants to merge 2 commits into from
+166 −11

Conversation

jxblum
Copy link
Contributor

@jxblum jxblum commented Sep 8, 2023

Closes #2692

@jxblum jxblum added the in: core Issues in core support label Sep 8, 2023
@mp911de mp911de self-assigned this Sep 12, 2023
@mp911de mp911de added the type: enhancement A general enhancement label Sep 12, 2023
@mp911de mp911de added this to the 3.2 M3 (2023.1.0) milestone Sep 12, 2023
mp911de pushed a commit that referenced this pull request Sep 12, 2023
@jxblum @mp911de
Adds support to lPop or rPop N elements from a Redis List in `Reactiv…
157f5e4 
…eListOperations`.

Closes #2692
Original pull request: #2704
mp911de added a commit that referenced this pull request Sep 12, 2023
@mp911de
Polishing.
9e473b5 
Reorder methods to align with ListOperations. Simplify tests to avoid test noise.

See #2692
Original pull request: #2704
@mp911de mp911de closed this Sep 12, 2023
@mp911de mp911de deleted the issue/2692 branch September 12, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees

@mp911de mp911de

Labels
in: core Issues in core support type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M3 (2023.1.0)
Development

Successfully merging this pull request may close these issues.

Add support to (Left|Right) Pop N elements using ReactiveListOperations
2 participants
@jxblum @mp911de