Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IPv6 hostnames to Converters. #2679

Closed
wants to merge 1 commit into from
Closed

Add support for IPv6 hostnames to Converters. #2679

wants to merge 1 commit into from

Conversation

TheTweak
Copy link
Contributor

@TheTweak TheTweak commented Aug 15, 2023 •
edited
Loading

Closes #2678

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@TheTweak Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 15, 2023
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 16, 2023
@mp911de mp911de added this to the 3.0.9 (2022.0.9) milestone Aug 16, 2023
mp911de pushed a commit that referenced this pull request Aug 16, 2023
@TheTweak @mp911de
Add support for bracket-less IPv6 addresses to CLUSTER NODES Converter.
020ef9c 
Closes #2678
Original pull request: #2679
mp911de added a commit that referenced this pull request Aug 16, 2023
@mp911de
Polishing.
3d6dacc 
Use Regex to capture the various styles of CLUSTER NODES endpoint representations.

See #2678
Original pull request: #2679
mp911de pushed a commit that referenced this pull request Aug 16, 2023
@TheTweak @mp911de
Add support for bracket-less IPv6 addresses to CLUSTER NODES Converter.
d1908fd 
Closes #2678
Original pull request: #2679
mp911de added a commit that referenced this pull request Aug 16, 2023
@mp911de
Polishing.
372d26a 
Use Regex to capture the various styles of CLUSTER NODES endpoint representations.

See #2678
Original pull request: #2679
mp911de pushed a commit that referenced this pull request Aug 16, 2023
@TheTweak @mp911de
Add support for bracket-less IPv6 addresses to CLUSTER NODES Converter.
0e0f34a 
Closes #2678
Original pull request: #2679
mp911de added a commit that referenced this pull request Aug 16, 2023
@mp911de
Polishing.
2b9b8c2 
Use Regex to capture the various styles of CLUSTER NODES endpoint representations.

See #2678
Original pull request: #2679
@mp911de
Copy link
Member

mp911de commented Aug 16, 2023

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Aug 16, 2023
@pivotal-cla
Copy link

@TheTweak Thank you for signing the Contributor License Agreement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.0.9 (2022.0.9)
Development

Successfully merging this pull request may close these issues.

IPv6 support for org.springframework.data.redis.connection.convert.Converters.ClusterNodesConverter#convert
4 participants
@TheTweak @pivotal-cla @mp911de @spring-projects-issues