Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce executor configuration to connection factories for Executor to be used with ClusterCommandExecutor #2669

Closed
wants to merge 4 commits into from
Closed

Introduce executor configuration to connection factories for Executor to be used with ClusterCommandExecutor #2669

wants to merge 4 commits into from

Commits on Aug 17, 2023

  1. Prepare issue branch for 2594.

    @jxblum @mp911de
    jxblum authored and mp911de committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    23cd048 View commit details
    Browse the repository at this point in the history

  2. Polishing. 

    Organize source code and cleanup compiler warnings.

See #2594
Original pull request: #2669
    @jxblum @mp911de
    jxblum authored and mp911de committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d43a46e View commit details
    Browse the repository at this point in the history

  3. Add configuration for TaskExecutor used by ClusterCommandsExecutor. 

    This change allows users to leverage the VirtualThread facilities and AsyncTaskExecutor implementations provided in and by the core Spring Framework as part of our Loom support theme.

Closes #2594
Original pull request: #2669
    @jxblum @mp911de
    jxblum authored and mp911de committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    5edfbac View commit details
    Browse the repository at this point in the history

  4. Polishing. 

    Move executor from ClusterConfiguration to connection factories as the executor is a Spring concept that isn't tied to endpoint details or the client config.

Reorder static factory methods after constructors and property accessors after static factory methods. Inline single-line single-use methods that aren't intended as extension hooks for easier readability.

Disable TaskExecutor disposal on ClusterCommandExecutor.destroy().

Remove NonNull annotations as default non-nullability is defined on the package level.

Simplify tests to use integration tests to avoid excessive mocking.

See #2594
Original pull request: #2669
    @mp911de
    mp911de committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b24231d View commit details
    Browse the repository at this point in the history