Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to (Left|Right) Pop N elements using ReactiveListOperations #2692

Closed
ericsouza opened this issue Aug 29, 2023 · 1 comment
Closed

Add support to (Left|Right) Pop N elements using ReactiveListOperations #2692

ericsouza opened this issue Aug 29, 2023 · 1 comment
Assignees
@jxblum
Labels
type: enhancement A general enhancement
Milestone
3.2 M3 (2023.1.0)

Comments

@ericsouza
Copy link

Hey, thanks for this amazing library!

I was converting my blocking ListOperations that uses a leftPop(key, count) to a reactive version. But it seems that the ReactiveListOperations does not have an option to pop N elements. Is there any reason for that?
@ericsouza ericsouza changed the title Pop N elements using ReactiveListOperation Pop N elements using ReactiveListOperations Aug 29, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2023
@mp911de
Copy link
Member

mp911de commented Aug 29, 2023 •
edited by jxblum
Loading

Seems like an oversight on our end. leftPop was introduced with version 2.6.0, there is even a lPop method on the list connection commands interface.

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 29, 2023
@mp911de mp911de changed the title Pop N elements using ReactiveListOperations Add support to (Left|Right) Pop N elements using ReactiveListOperations Aug 29, 2023
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 7, 2023
@jxblum
Adds support to lPop or rPop N elements (count) in ReactiveListOperat…
ac1ee1e 
…ions.

Closes spring-projects#2692
jxblum added a commit to jxblum/spring-data-redis that referenced this issue Sep 8, 2023
@jxblum
Adds support to lPop or rPop N elements from a Redis List in Reactive…
d96693c 
…ListOperations.

Closes spring-projects#2692
@jxblum jxblum mentioned this issue Sep 8, 2023
Closed
@mp911de mp911de added this to the 3.2 M3 (2023.1.0) milestone Sep 12, 2023
mp911de added a commit that referenced this issue Sep 12, 2023
@mp911de
Polishing.
9e473b5 
Reorder methods to align with ListOperations. Simplify tests to avoid test noise.

See #2692
Original pull request: #2704
@mp911de mp911de mentioned this issue Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jxblum jxblum

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M3 (2023.1.0)
4 participants
@mp911de @jxblum @ericsouza @spring-projects-issues