Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample or instructions for Google OAuth #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dalrympm
Copy link

I've extended the github example to include Google's OAuth2. I determined that by supplying the OAuth2RestTemplate to the UserInfoTokenServices I was able to get AuthenticationScheme.query used when retrieving the User Info. Applying the change to all ssoFilter() requests didn't seem to have any negative consequences but I could very well be missing something and would appreciate any feedback.

I've committed my own clientId and clientSecret that I've only used for this purpose, not sure what additional ramifications there may be for doing so.

Note that I did not make any changes to the TokenType (i.e. from Bearer to bearer) as mentioned elsewhere on the internets.

Fixes #5

@dsyer dsyer changed the title Sample Google OAuth Add sample or instructions for Google OAuth Aug 2, 2016
@dsyer
Copy link
Collaborator

dsyer commented Aug 2, 2016

Google is a popular provider, so I'm sort of interested in this as at least a sidebar in the text (not sure if the code needs it, but it's pretty minimal., so maybe it's worth it). I'd be even more interested in a new sample app just for google that added some new features, like restricting authentication to a particular domain or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants