Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.adoc #22

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

RanyAlbegWein
Copy link
Contributor

Update dependencies in Spring Initializr URL from 'cloud-gateway' to 'cloud-gateway-reactive' to support the RouteLocator demonstrated in the code.

Update dependencies in Spring Initializr URL from 'cloud-gateway' to 'cloud-gateway-reactive' to support the RouteLocator demonstrated in the code.
@robertmcnees
Copy link
Contributor

Hi @RanyAlbegWein. Thank you for the PR! Good catch that the link to start.spring.io grabs the wrong dependencies.

Can you update the PR to also change the text in this line? The guide references Gateway when it should now reference Reactive Gateway.

For reference, this change was made for Boot 3.2 and later. The details are discussed in this issue in the Spring Initilizr repository. When you use Boot 3.2 or later, adding the Gateway dependency will pull in spring-cloud-starter-gateway-mvc instead of the previous spring-cloud-starter-gateway.

@robertmcnees
Copy link
Contributor

Additionally, you could remove this parameter from the link:

&jvmVersion=11

Java 11 is not a valid selection so Spring Initializr defaults to 17 anyhow. Removing it completely will let Spring Initializr select the version, which is the desired behavior.

Modified instructions to include Reactive Gateway as one of the dependencies instead of Gateway.
Removed jvmVersion=11 to let Initializr auto-select JDK
@RanyAlbegWein
Copy link
Contributor Author

Thank you for the review! Modified as per your request.

@robertmcnees robertmcnees merged commit 06b58c6 into spring-guides:main May 7, 2024
1 check passed
@robertmcnees
Copy link
Contributor

Thank you for the contribution!

@RanyAlbegWein
Copy link
Contributor Author

RanyAlbegWein commented May 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants