Allow backup opt out #121
Open
Allow backup opt out #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPTElyasn
reviewed
Jan 17, 2020
| @@ -51,6 +51,7 @@ - (instancetype)init | |||
| _cachePath = [NSTemporaryDirectory() stringByAppendingPathComponent:@"/com.spotify.temppersistent.image.cache"]; | |||
| _cacheIdentifier = @"persistent.cache"; | |||
| _useDirectorySeparation = YES; | |||
| _shouldExcludeFromBackup = NO; | |||
There was a problem hiding this comment.
@aodhol You probably need to provide the deep copy of this. You have it down there in copyWithZone
There was a problem hiding this comment.
Not super important but would be nice to include it in debugDescription.
SPTElyasn
reviewed
Jan 22, 2020
| @@ -114,6 +114,12 @@ FOUNDATION_EXPORT const NSUInteger SPTPersistentCacheMinimumExpirationLimit; | |||
| */ | |||
| @property (nonatomic, copy) NSString *cachePath; | |||
|
|
|||
| /** | |||
| Excludes the cache directory from backup. | |||
| @discussion Some users may wish to have the cache directory excluded from backup. | |||
There was a problem hiding this comment.
@aodhol In order to avoid any confusion, would be nice to mention the default value here maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an option to exclude the cache directory from backup the first time it is created.